From: Song Liu Date: Mon, 10 May 2021 06:49:17 +0000 (-0700) Subject: perf build: Improve error message for old/missing clang X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=efb0b2328196d78706a2d63c13802f45e8b87090;p=linux.git perf build: Improve error message for old/missing clang clang is required to build perf with BUILD_BPF_SKEL=1. Improve the error message to highlight that: 1) clang could be either missing or too old; 2) clang is only required with BUILD_BPF_SKEL=1. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Song Liu Cc: Jiri Olsa Signed-off-by: Arnaldo Carvalho de Melo --- diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 406a9519145e5..829e0498bd510 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -635,7 +635,7 @@ endif ifdef BUILD_BPF_SKEL $(call feature_check,clang-bpf-co-re) ifeq ($(feature-clang-bpf-co-re), 0) - dummy := $(error Error: clang too old. Please install recent clang) + dummy := $(error Error: clang too old/not installed. Please install recent clang to build with BUILD_BPF_SKEL) endif $(call detected,CONFIG_PERF_BPF_SKEL) CFLAGS += -DHAVE_BPF_SKEL