From: Bjorn Helgaas <bhelgaas@google.com>
Date: Sat, 5 Apr 2014 21:08:22 +0000 (-0600)
Subject: PCI: Remove dead code
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=efdd4070f38e962d69c11f23c5aa033121a8cf0f;p=linux.git

PCI: Remove dead code

"pdev" can never be NULL here, so remove the test.

Found by Coverity (CID 744313).

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---

diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
index 650ce8935fd79..ff236ed4f5cf4 100644
--- a/drivers/pci/pci-driver.c
+++ b/drivers/pci/pci-driver.c
@@ -1345,8 +1345,6 @@ static int pci_uevent(struct device *dev, struct kobj_uevent_env *env)
 		return -ENODEV;
 
 	pdev = to_pci_dev(dev);
-	if (!pdev)
-		return -ENODEV;
 
 	if (add_uevent_var(env, "PCI_CLASS=%04X", pdev->class))
 		return -ENOMEM;
@@ -1367,6 +1365,7 @@ static int pci_uevent(struct device *dev, struct kobj_uevent_env *env)
 			   (u8)(pdev->class >> 16), (u8)(pdev->class >> 8),
 			   (u8)(pdev->class)))
 		return -ENOMEM;
+
 	return 0;
 }