From: Richard Henderson <richard.henderson@linaro.org>
Date: Fri, 21 Oct 2022 01:00:35 +0000 (+1000)
Subject: tcg: Simplify calls to temp_sync vs mem_coherent
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f01847c251c24beaf3a0a41764d331355d08ab54;p=qemu.git

tcg: Simplify calls to temp_sync vs mem_coherent

The first thing that temp_sync does is check mem_coherent,
so there's no need for the caller to do so.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---

diff --git a/tcg/tcg.c b/tcg/tcg.c
index 8b2193409a..034d1b6604 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -4083,12 +4083,8 @@ static bool tcg_reg_alloc_dup2(TCGContext *s, const TCGOp *op)
 
     /* If the two inputs form one 64-bit value, try dupm_vec. */
     if (itsl + 1 == itsh && itsl->base_type == TCG_TYPE_I64) {
-        if (!itsl->mem_coherent) {
-            temp_sync(s, itsl, s->reserved_regs, 0, 0);
-        }
-        if (!itsh->mem_coherent) {
-            temp_sync(s, itsh, s->reserved_regs, 0, 0);
-        }
+        temp_sync(s, itsl, s->reserved_regs, 0, 0);
+        temp_sync(s, itsh, s->reserved_regs, 0, 0);
 #if HOST_BIG_ENDIAN
         TCGTemp *its = itsh;
 #else