From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Date: Sun, 8 Jul 2018 01:26:50 +0000 (-0700)
Subject: rcuperf: Warn on bad perf type for built-in tests
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f0288064425ff9a5e05c8c0fdba6ec7681dd3330;p=linux.git

rcuperf: Warn on bad perf type for built-in tests

When running a built-in rcuperf test, specifying an invalid perf type
results in what looks like a hard hang, with the error messages hidden
by other boot-time output.  This commit therefore executes a WARN_ON()
in this case so that the splat appears just following the error messages.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
---

diff --git a/kernel/rcu/rcuperf.c b/kernel/rcu/rcuperf.c
index 34244523550e1..832ce68fd45fe 100644
--- a/kernel/rcu/rcuperf.c
+++ b/kernel/rcu/rcuperf.c
@@ -680,6 +680,7 @@ rcu_perf_init(void)
 		for (i = 0; i < ARRAY_SIZE(perf_ops); i++)
 			pr_cont(" %s", perf_ops[i]->name);
 		pr_cont("\n");
+		WARN_ON(!IS_MODULE(CONFIG_RCU_PERF_TEST));
 		firsterr = -EINVAL;
 		goto unwind;
 	}