From: Al Viro Date: Wed, 19 Feb 2020 04:05:39 +0000 (-0500) Subject: fat_dir_ioctl(): hadn't needed that access_ok() for more than a decade... X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f06d3a7e6ebe4faf94cf0be1b25ae6df33620d88;p=linux.git fat_dir_ioctl(): hadn't needed that access_ok() for more than a decade... address is passed only to put_user() and copy_to_user() Signed-off-by: Al Viro --- diff --git a/fs/fat/dir.c b/fs/fat/dir.c index 054acd9fd0331..b4ddf48fa4449 100644 --- a/fs/fat/dir.c +++ b/fs/fat/dir.c @@ -804,8 +804,6 @@ static long fat_dir_ioctl(struct file *filp, unsigned int cmd, return fat_generic_ioctl(filp, cmd, arg); } - if (!access_ok(d1, sizeof(struct __fat_dirent[2]))) - return -EFAULT; /* * Yes, we don't need this put_user() absolutely. However old * code didn't return the right value. So, app use this value, @@ -844,8 +842,6 @@ static long fat_compat_dir_ioctl(struct file *filp, unsigned cmd, return fat_generic_ioctl(filp, cmd, (unsigned long)arg); } - if (!access_ok(d1, sizeof(struct compat_dirent[2]))) - return -EFAULT; /* * Yes, we don't need this put_user() absolutely. However old * code didn't return the right value. So, app use this value,