From: Christophe JAILLET Date: Wed, 17 Jun 2020 19:53:26 +0000 (+0200) Subject: pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in case of error X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f15480e947d45959f0bcfba7318d369eebe47a59;p=linux.git pcmcia/electra_cf: Fix some return values in 'electra_cf_probe()' in case of error 'status' is known to be 0 at this point. It must be set to a meaningful value in order to return an error code if one of the 'of_get_property()' call fails. Return -EINVAL in such a case. Fixes: 2b571a066a2f("pcmcia: CompactFlash driver for PA Semi Electra boards") Signed-off-by: Christophe JAILLET Acked-by: Olof Johansson Signed-off-by: Dominik Brodowski --- diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c index 35158cfd9c1a3..40a5cffe24a4c 100644 --- a/drivers/pcmcia/electra_cf.c +++ b/drivers/pcmcia/electra_cf.c @@ -229,6 +229,8 @@ static int electra_cf_probe(struct platform_device *ofdev) cf->socket.pci_irq = cf->irq; + status = -EINVAL; + prop = of_get_property(np, "card-detect-gpio", NULL); if (!prop) goto fail1;