From: Kevin Wolf <kwolf@redhat.com>
Date: Fri, 4 Apr 2014 15:07:19 +0000 (+0200)
Subject: block: Check bdrv_getlength() return value in bdrv_append_temp_snapshot()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f187743acd39747cc8cc32111518142c924963b9;p=qemu.git

block: Check bdrv_getlength() return value in bdrv_append_temp_snapshot()

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
---

diff --git a/block.c b/block.c
index d89c344a13..990a7542a9 100644
--- a/block.c
+++ b/block.c
@@ -1184,7 +1184,12 @@ void bdrv_append_temp_snapshot(BlockDriverState *bs, Error **errp)
        instead of opening 'filename' directly */
 
     /* Get the required size from the image */
-    total_size = bdrv_getlength(bs) & BDRV_SECTOR_MASK;
+    total_size = bdrv_getlength(bs);
+    if (total_size < 0) {
+        error_setg_errno(errp, -total_size, "Could not get image size");
+        return;
+    }
+    total_size &= BDRV_SECTOR_MASK;
 
     /* Create the temporary image */
     ret = get_tmp_filename(tmp_filename, sizeof(tmp_filename));