From: Coiby Xu Date: Fri, 18 Sep 2020 08:09:07 +0000 (+0800) Subject: libvhost-user: remove watch for kick_fd when de-initialize vu-dev X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f1baeee9ffeddcc068d3536f90b5c3e9f81d9309;p=qemu.git libvhost-user: remove watch for kick_fd when de-initialize vu-dev When the client is running in gdb and quit command is run in gdb, QEMU will still dispatch the event which will cause segment fault in the callback function. Signed-off-by: Coiby Xu Reviewed-by: Stefan Hajnoczi Reviewed-by: Marc-André Lureau Message-id: 20200918080912.321299-3-coiby.xu@gmail.com Signed-off-by: Stefan Hajnoczi --- diff --git a/contrib/libvhost-user/libvhost-user.c b/contrib/libvhost-user/libvhost-user.c index 09bdff18f3..bfec8a881a 100644 --- a/contrib/libvhost-user/libvhost-user.c +++ b/contrib/libvhost-user/libvhost-user.c @@ -1918,6 +1918,7 @@ vu_deinit(VuDev *dev) } if (vq->kick_fd != -1) { + dev->remove_watch(dev, vq->kick_fd); close(vq->kick_fd); vq->kick_fd = -1; }