From: Hanjun Guo <guohanjun@huawei.com>
Date: Tue, 22 Nov 2022 08:53:28 +0000 (+0800)
Subject: ACPI: fan: Bail out if extract package failed
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f2ae44ae5335864794acb5b0490746ba9db3ccd7;p=linux.git

ACPI: fan: Bail out if extract package failed

Bail out if we extract the _FIF package failed, or we will end
of referencing the garbage information in fields[], the fan control
will be in mess, fix it.

Fiexes: d445571fa369 ("ACPI: fan: Optimize struct acpi_fan_fif")
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/acpi/fan_core.c b/drivers/acpi/fan_core.c
index 52a0b303b70aa..9dccbae9e8ea7 100644
--- a/drivers/acpi/fan_core.c
+++ b/drivers/acpi/fan_core.c
@@ -236,6 +236,7 @@ static int acpi_fan_get_fif(struct acpi_device *device)
 	if (ACPI_FAILURE(status)) {
 		dev_err(&device->dev, "Invalid _FIF element\n");
 		status = -EINVAL;
+		goto err;
 	}
 
 	fan->fif.revision = fields[0];