From: Christoph Hellwig <hch@lst.de>
Date: Mon, 13 Jun 2022 05:37:14 +0000 (+0200)
Subject: fs: don't call ->writepage from __mpage_writepage
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f2d3e573bff9fde1566a4a1d0c7372fa5b4fd9ee;p=linux.git

fs: don't call ->writepage from __mpage_writepage

All callers of mpage_writepage use block_write_full_page as their
->writepage implementation when called from mpage_writepages
(although for ntfs3 this is obsfucated a bit).

Just call block_write_full_page directly instead of going through
the ->writepage indirection.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---

diff --git a/fs/mpage.c b/fs/mpage.c
index b7e0b7fbb41f2..bf7d1cf621e2f 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -626,7 +626,7 @@ confused:
 	/*
 	 * The caller has a ref on the inode, so *mapping is stable
 	 */
-	ret = mapping->a_ops->writepage(page, wbc);
+	ret = block_write_full_page(page, mpd->get_block, wbc);
 	mapping_set_error(mapping, ret);
 out:
 	mpd->bio = bio;