From: Chengguang Xu <cgxu519@gmail.com>
Date: Mon, 6 May 2019 11:01:02 +0000 (+0800)
Subject: staging: erofs: set sb->s_root to NULL when failing from __getname()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f2dcb8841e6b155da098edae09125859ef7e853d;p=linux.git

staging: erofs: set sb->s_root to NULL when failing from __getname()

Set sb->s_root to NULL when failing from __getname(),
so that we can avoid double dput and unnecessary operations
in generic_shutdown_super().

Signed-off-by: Chengguang Xu <cgxu519@gmail.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/erofs/super.c b/drivers/staging/erofs/super.c
index 399847d211466..f580d4ef77a1b 100644
--- a/drivers/staging/erofs/super.c
+++ b/drivers/staging/erofs/super.c
@@ -457,6 +457,7 @@ static int erofs_read_super(struct super_block *sb,
 	 */
 err_devname:
 	dput(sb->s_root);
+	sb->s_root = NULL;
 err_iget:
 #ifdef EROFS_FS_HAS_MANAGED_CACHE
 	iput(sbi->managed_cache);