From: Lee Jones Date: Wed, 1 Jul 2020 08:58:49 +0000 (+0100) Subject: misc: genwqe: card_base: Remove set but unused variable 'rc' X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f33e92e50c82319718a21ec372f3df9eff59bfa9;p=linux.git misc: genwqe: card_base: Remove set but unused variable 'rc' Variable 'rc' hasn't been checked since the driver's inception in 2013. If it hasn't caused any issues since then, it's unlikely to in the future. Let's take it out for now. Fixes the following W=1 kernel build warning(s): drivers/misc/genwqe/card_base.c: In function ‘genwqe_health_check_stop’: /home/lee/projects/linux/kernel/drivers/misc/genwqe/card_base.c:1046:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] 1046 | int rc; | ^~ Cc: Michael Jung Cc: Michael Ruettger Cc: Frank Haverkamp Cc: Joerg-Stephan Vogt Signed-off-by: Lee Jones Reviewed-by: Frank Haverkamp Link: https://lore.kernel.org/r/20200701085853.164358-17-lee.jones@linaro.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c index 9969c0003f159..0e83192a82854 100644 --- a/drivers/misc/genwqe/card_base.c +++ b/drivers/misc/genwqe/card_base.c @@ -1043,12 +1043,10 @@ static int genwqe_health_thread_running(struct genwqe_dev *cd) static int genwqe_health_check_stop(struct genwqe_dev *cd) { - int rc; - if (!genwqe_health_thread_running(cd)) return -EIO; - rc = kthread_stop(cd->health_thread); + kthread_stop(cd->health_thread); cd->health_thread = NULL; return 0; }