From: Markus Armbruster <armbru@redhat.com>
Date: Thu, 28 Nov 2013 16:26:57 +0000 (+0100)
Subject: apic: Document why cannot_instantiate_with_device_add_yet
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f37a4374bae20ca678b808b5ee32319e943b1b4b;p=qemu.git

apic: Document why cannot_instantiate_with_device_add_yet

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---

diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index ea420c7188..aaef0543bc 100644
--- a/hw/intc/apic_common.c
+++ b/hw/intc/apic_common.c
@@ -386,9 +386,13 @@ static void apic_common_class_init(ObjectClass *klass, void *data)
 
     dc->vmsd = &vmstate_apic_common;
     dc->reset = apic_reset_common;
-    dc->cannot_instantiate_with_device_add_yet = true; /* FIXME explain why */
     dc->props = apic_properties_common;
     idc->init = apic_init_common;
+    /*
+     * Reason: APIC and CPU need to be wired up by
+     * x86_cpu_apic_create()
+     */
+    dc->cannot_instantiate_with_device_add_yet = true;
 }
 
 static const TypeInfo apic_common_type = {