From: Markus Armbruster Date: Sat, 3 Feb 2024 08:02:26 +0000 (+0100) Subject: tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f396da77ca59cc67fedb54fe4ea22fbb961270d3;p=qemu.git tests/unit/test-char: Fix qemu_socket(), make_udp_socket() check qemu_socket() and make_udp_socket() return a file descriptor on success, -1 on failure. The check misinterprets 0 as failure. Fix that. Signed-off-by: Markus Armbruster Message-ID: <20240203080228.2766159-3-armbru@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Eric Blake --- diff --git a/tests/unit/test-char.c b/tests/unit/test-char.c index 2aea49c3b6..f273ce5226 100644 --- a/tests/unit/test-char.c +++ b/tests/unit/test-char.c @@ -556,7 +556,7 @@ static int make_udp_socket(int *port) socklen_t alen = sizeof(addr); int ret, sock = qemu_socket(PF_INET, SOCK_DGRAM, 0); - g_assert_cmpint(sock, >, 0); + g_assert_cmpint(sock, >=, 0); addr.sin_family = AF_INET ; addr.sin_addr.s_addr = htonl(INADDR_ANY); addr.sin_port = 0; @@ -1407,7 +1407,7 @@ static void char_hotswap_test(void) int port; int sock = make_udp_socket(&port); - g_assert_cmpint(sock, >, 0); + g_assert_cmpint(sock, >=, 0); chr_args = g_strdup_printf("udp:127.0.0.1:%d", port);