From: Thomas Zimmermann Date: Fri, 25 Jun 2021 08:21:57 +0000 (+0200) Subject: drm/hibmc: Call drm_irq_uninstall() unconditionally X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f4b62145f47b95b81116bab2cecb832a87df777c;p=linux.git drm/hibmc: Call drm_irq_uninstall() unconditionally Remove the check around drm_irq_uninstall(). The same test is done by the function internally. The tested state in irq_enabled is considered obsolete and should not be used by KMS drivers. Signed-off-by: Thomas Zimmermann Reviewed-by: Laurent Pinchart Acked-by: Tian Tao Acked-by: Daniel Vetter Link: https://patchwork.freedesktop.org/patch/msgid/20210625082222.3845-3-tzimmermann@suse.de --- diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index f4bc5386574af..f8ef711bbe5da 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -253,8 +253,7 @@ static int hibmc_unload(struct drm_device *dev) { drm_atomic_helper_shutdown(dev); - if (dev->irq_enabled) - drm_irq_uninstall(dev); + drm_irq_uninstall(dev); pci_disable_msi(to_pci_dev(dev->dev));