From: Sudeep Holla <sudeep.holla@arm.com>
Date: Fri, 17 Apr 2020 10:32:32 +0000 (+0100)
Subject: firmware: arm_scmi: Fix return error code in smc_send_message
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f7199cf489027ae38a9a82312d13025f7aefa0b8;p=linux.git

firmware: arm_scmi: Fix return error code in smc_send_message

SMCCC can return NOT_SUPPORTED(-1). Map it to appropriate Linux error
codes namely -EOPNOTSUPP.

Link: https://lore.kernel.org/r/20200417103232.6896-1-sudeep.holla@arm.com
Reported-and-Tested-by:: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---

diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c
index 833e793b53913..49bc4b0e84285 100644
--- a/drivers/firmware/arm_scmi/smc.c
+++ b/drivers/firmware/arm_scmi/smc.c
@@ -114,7 +114,10 @@ static int smc_send_message(struct scmi_chan_info *cinfo,
 
 	mutex_unlock(&scmi_info->shmem_lock);
 
-	return res.a0;
+	/* Only SMCCC_RET_NOT_SUPPORTED is valid error code */
+	if (res.a0)
+		return -EOPNOTSUPP;
+	return 0;
 }
 
 static void smc_fetch_response(struct scmi_chan_info *cinfo,