From: Markus Elfring Date: Sat, 4 Apr 2020 15:07:34 +0000 (+0200) Subject: hwrng: xgene - Delete an error message in xgene_rng_probe() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f72fed86a5ac80445c7723d3fc782325a23bc7db;p=linux.git hwrng: xgene - Delete an error message in xgene_rng_probe() The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Herbert Xu --- diff --git a/drivers/char/hw_random/xgene-rng.c b/drivers/char/hw_random/xgene-rng.c index d7516a446987b..008e6db9ce010 100644 --- a/drivers/char/hw_random/xgene-rng.c +++ b/drivers/char/hw_random/xgene-rng.c @@ -328,10 +328,8 @@ static int xgene_rng_probe(struct platform_device *pdev) return PTR_ERR(ctx->csr_base); rc = platform_get_irq(pdev, 0); - if (rc < 0) { - dev_err(&pdev->dev, "No IRQ resource\n"); + if (rc < 0) return rc; - } ctx->irq = rc; dev_dbg(&pdev->dev, "APM X-Gene RNG BASE %p ALARM IRQ %d",