From: Chris Wilson Date: Tue, 19 May 2020 06:31:15 +0000 (+0100) Subject: drm/i915/selftests: Check for an initial-breadcrumb in wait_for_submit() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f73fbb5a59a7060f81afe4f924a69ab6bff0c46d;p=linux.git drm/i915/selftests: Check for an initial-breadcrumb in wait_for_submit() When we look at i915_request_is_started() we must be careful in case we are using a request that does not have the initial-breadcrumb and instead the is-started is being compared against the end of the previous request. This will make wait_for_submit() declare that a request has been already submitted too early. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala Link: https://patchwork.freedesktop.org/patch/msgid/20200519063123.20673-4-chris@chris-wilson.co.uk --- diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index b71f04db9c6e5..f6949cd55e929 100644 --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c @@ -75,7 +75,7 @@ static bool is_active(struct i915_request *rq) if (i915_request_on_hold(rq)) return true; - if (i915_request_started(rq)) + if (i915_request_has_initial_breadcrumb(rq) && i915_request_started(rq)) return true; return false;