From: Huaisheng Ye Date: Mon, 30 Jul 2018 07:15:47 +0000 (+0800) Subject: md/dm-writecache: Don't request pointer dummy_addr when not required X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f742267ae91faf241d2892878208dffc586ffe06;p=linux.git md/dm-writecache: Don't request pointer dummy_addr when not required Function persistent_memory_claim doesn't need to get local pointer dummy_addr from direct_access. Using NULL instead of having to pass in a useless local pointer that caller then just throw away. Suggested-by: Ross Zwisler Signed-off-by: Huaisheng Ye Reviewed-by: Ross Zwisler Acked-by: Mike Snitzer Signed-off-by: Dave Jiang --- diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index 5961c7794ef37..1839236a0f815 100644 --- a/drivers/md/dm-writecache.c +++ b/drivers/md/dm-writecache.c @@ -267,9 +267,8 @@ static int persistent_memory_claim(struct dm_writecache *wc) i = 0; do { long daa; - void *dummy_addr; daa = dax_direct_access(wc->ssd_dev->dax_dev, i, p - i, - &dummy_addr, &pfn); + NULL, &pfn); if (daa <= 0) { r = daa ? daa : -EINVAL; goto err3;