From: Michal Kubecek Date: Fri, 26 Apr 2019 09:13:12 +0000 (+0200) Subject: net: fix two coding style issues X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f78c6032c4cb89b408190afd4feb61ff4461a114;p=linux.git net: fix two coding style issues This is a simple cleanup addressing two coding style issues found by checkpatch.pl in an earlier patch. It's submitted as a separate patch to keep the original patch as it was generated by spatch. Signed-off-by: Michal Kubecek Signed-off-by: David S. Miller --- diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 0914477c47197..348ddb6d09bba 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -413,9 +413,9 @@ static int br_fill_ifinfo(struct sk_buff *skb, goto nla_put_failure; if (event == RTM_NEWLINK && port) { - struct nlattr *nest - = nla_nest_start(skb, IFLA_PROTINFO); + struct nlattr *nest; + nest = nla_nest_start(skb, IFLA_PROTINFO); if (nest == NULL || br_port_fill_attrs(skb, port) < 0) goto nla_put_failure; nla_nest_end(skb, nest); diff --git a/net/decnet/dn_table.c b/net/decnet/dn_table.c index 2fb764321b97a..33fefb0aebca4 100644 --- a/net/decnet/dn_table.c +++ b/net/decnet/dn_table.c @@ -348,7 +348,8 @@ static int dn_fib_dump_info(struct sk_buff *skb, u32 portid, u32 seq, int event, struct rtnexthop *nhp; struct nlattr *mp_head; - if (!(mp_head = nla_nest_start_noflag(skb, RTA_MULTIPATH))) + mp_head = nla_nest_start_noflag(skb, RTA_MULTIPATH); + if (!mp_head) goto errout; for_nexthops(fi) {