From: Kent Overstreet <kent.overstreet@gmail.com>
Date: Tue, 29 Oct 2019 07:57:58 +0000 (-0400)
Subject: bcachefs: Don't use extent_ptr_decoded_append() in write path (fixup patch)
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f7f63211a4e7ecc4c56e3bc1062a4f9711dfd0aa;p=linux.git

bcachefs: Don't use extent_ptr_decoded_append() in write path (fixup patch)

bch2_extent_ptr_decoded_append() is more general than we need here; we
know we're initializing a new extent so e.g. we're going to need the crc
entry.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/io.c b/fs/bcachefs/io.c
index 3f075dcfafb26..567a553112d17 100644
--- a/fs/bcachefs/io.c
+++ b/fs/bcachefs/io.c
@@ -631,10 +631,12 @@ static void init_append_extent(struct bch_write_op *op,
 			       struct bversion version,
 			       struct bch_extent_crc_unpacked crc)
 {
-	struct bkey_i_extent *e = bkey_extent_init(op->insert_keys.top);
+	struct bkey_i_extent *e;
 	struct bch_extent_ptr *ptr;
 
 	op->pos.offset += crc.uncompressed_size;
+
+	e = bkey_extent_init(op->insert_keys.top);
 	e->k.p		= op->pos;
 	e->k.size	= crc.uncompressed_size;
 	e->k.version	= version;