From: Dan Carpenter Date: Mon, 3 Dec 2018 14:52:19 +0000 (+0300) Subject: misc: vexpress: Off by one in vexpress_syscfg_exec() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f8a70d8b889f180e6860cb1f85fed43d37844c5a;p=linux.git misc: vexpress: Off by one in vexpress_syscfg_exec() The > comparison should be >= to prevent reading beyond the end of the func->template[] array. (The func->template array is allocated in vexpress_syscfg_regmap_init() and it has func->num_templates elements.) Fixes: 974cc7b93441 ("mfd: vexpress: Define the device as MFD cells") Signed-off-by: Dan Carpenter Acked-by: Sudeep Holla Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c index 6c3591cdf8555..a3c6c773d9dc8 100644 --- a/drivers/misc/vexpress-syscfg.c +++ b/drivers/misc/vexpress-syscfg.c @@ -61,7 +61,7 @@ static int vexpress_syscfg_exec(struct vexpress_syscfg_func *func, int tries; long timeout; - if (WARN_ON(index > func->num_templates)) + if (WARN_ON(index >= func->num_templates)) return -EINVAL; command = readl(syscfg->base + SYS_CFGCTRL);