From: Sebastian Andrzej Siewior Date: Fri, 1 Mar 2024 21:45:28 +0000 (+0100) Subject: serial: pch: Don't disable interrupts while acquiring lock in ISR. X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f8ff23ebce8c305383c8070e1ea3b08a69eb1e8d;p=linux.git serial: pch: Don't disable interrupts while acquiring lock in ISR. The interrupt service routine is always invoked with disabled interrupts. Remove the _irqsave() from the locking functions in the interrupts service routine/ pch_uart_interrupt(). Signed-off-by: Sebastian Andrzej Siewior Link: https://lore.kernel.org/r/20240301215246.891055-16-bigeasy@linutronix.de Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 124eb816fca7e..6e259f4139153 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -1010,11 +1010,10 @@ static irqreturn_t pch_uart_interrupt(int irq, void *dev_id) u8 lsr; int ret = 0; unsigned char iid; - unsigned long flags; int next = 1; u8 msr; - spin_lock_irqsave(&priv->lock, flags); + spin_lock(&priv->lock); handled = 0; while (next) { iid = pch_uart_hal_get_iid(priv); @@ -1074,7 +1073,7 @@ static irqreturn_t pch_uart_interrupt(int irq, void *dev_id) handled |= (unsigned int)ret; } - spin_unlock_irqrestore(&priv->lock, flags); + spin_unlock(&priv->lock); return IRQ_RETVAL(handled); }