From: Philippe Mathieu-Daudé Date: Sat, 19 Oct 2019 23:47:13 +0000 (+0200) Subject: hw/arm/highbank: Use AddressSpace when using write_secondary_boot() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f9469c1a01c333c08980e083e0ad3417256c8b9c;p=qemu.git hw/arm/highbank: Use AddressSpace when using write_secondary_boot() write_secondary_boot() is used in SMP configurations where the CPU address space might not be the main System Bus. The rom_add_blob_fixed_as() function allow us to specify an address space. Use it to write each boot blob in the corresponding CPU address space. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis Message-id: 20191019234715.25750-15-f4bug@amsat.org Signed-off-by: Peter Maydell --- diff --git a/hw/arm/highbank.c b/hw/arm/highbank.c index f1724d6929..518d935fdf 100644 --- a/hw/arm/highbank.c +++ b/hw/arm/highbank.c @@ -78,7 +78,8 @@ static void hb_write_secondary(ARMCPU *cpu, const struct arm_boot_info *info) for (n = 0; n < ARRAY_SIZE(smpboot); n++) { smpboot[n] = tswap32(smpboot[n]); } - rom_add_blob_fixed("smpboot", smpboot, sizeof(smpboot), SMP_BOOT_ADDR); + rom_add_blob_fixed_as("smpboot", smpboot, sizeof(smpboot), SMP_BOOT_ADDR, + arm_boot_address_space(cpu, info)); } static void hb_reset_secondary(ARMCPU *cpu, const struct arm_boot_info *info)