From: Markus Armbruster Date: Sun, 11 Feb 2018 09:35:59 +0000 (+0100) Subject: qapi/common: Fix guardname() for funny filenames X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=f9c146399dabefb8cd13c9c467a9e710af15ea70;p=qemu.git qapi/common: Fix guardname() for funny filenames guardname() fails to return a valid C identifier for arguments containing anything but [A-Za-z0-9_.-']. Fix that. Don't bother protecting ticklish identifiers; header guards are all-caps, and no ticklish identifiers are. Signed-off-by: Markus Armbruster Reviewed-by: Marc-André Lureau Reviewed-by: Eric Blake Message-Id: <20180211093607.27351-22-armbru@redhat.com> Reviewed-by: Michael Roth Signed-off-by: Eric Blake --- diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 547656c8b2..069ec3715d 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -1867,7 +1867,7 @@ def mcgen(code, **kwds): def guardname(filename): - return c_name(filename, protect=False).upper() + return re.sub(r'[^A-Za-z0-9_]', '_', filename).upper() def guardstart(name):