From: Uwe Kleine-König Date: Fri, 2 Dec 2022 18:35:12 +0000 (+0100) Subject: pwm: Don't initialize list head before calling list_add() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=fa1b9aa4492cc4f29178ef38ca0467c48714250e;p=linux.git pwm: Don't initialize list head before calling list_add() list_add() just overwrites the members of the element to add (here: chip->list) without any checks, even in the DEBUG_LIST case. So save the effort to initialize the list. Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20221117211143.3817381-5-u.kleine-koenig@pengutronix.de Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index b43b24bd3c9f1..61bacd8d9b44c 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -299,7 +299,6 @@ int pwmchip_add(struct pwm_chip *chip) radix_tree_insert(&pwm_tree, pwm->pwm, pwm); } - INIT_LIST_HEAD(&chip->list); list_add(&chip->list, &pwm_chips); mutex_unlock(&pwm_lock);