From: Jérôme Pouiller Date: Thu, 13 Jan 2022 08:55:02 +0000 (+0100) Subject: staging: wfx: replace magic value by WFX_HIF_BUFFER_SIZE X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=fa2b25321d3d8c666d6aa9991476867602f31e78;p=linux.git staging: wfx: replace magic value by WFX_HIF_BUFFER_SIZE Magic values are not recommended. Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20220113085524.1110708-10-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wfx/hwio.c b/drivers/staging/wfx/hwio.c index a2a37efc51a66..977b9325f4960 100644 --- a/drivers/staging/wfx/hwio.c +++ b/drivers/staging/wfx/hwio.c @@ -15,6 +15,8 @@ #include "bus.h" #include "traces.h" +#define WFX_HIF_BUFFER_SIZE 0x2000 + static int read32(struct wfx_dev *wdev, int reg, u32 *val) { int ret; @@ -103,7 +105,7 @@ static int indirect_read(struct wfx_dev *wdev, int reg, u32 addr, u32 cfg; u32 prefetch; - WARN_ON(len >= 0x2000); + WARN_ON(len >= WFX_HIF_BUFFER_SIZE); WARN_ON(reg != WFX_REG_AHB_DPORT && reg != WFX_REG_SRAM_DPORT); if (reg == WFX_REG_AHB_DPORT) @@ -151,7 +153,7 @@ static int indirect_write(struct wfx_dev *wdev, int reg, u32 addr, { int ret; - WARN_ON(len >= 0x2000); + WARN_ON(len >= WFX_HIF_BUFFER_SIZE); WARN_ON(reg != WFX_REG_AHB_DPORT && reg != WFX_REG_SRAM_DPORT); ret = write32(wdev, WFX_REG_BASE_ADDR, addr); if (ret < 0)