From: Rafael J. Wysocki Date: Fri, 14 Apr 2023 14:00:48 +0000 (+0200) Subject: ACPI: bus: Ensure that notify handlers are not running after removal X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=faae443738c6f0dac9b0d3d11d108f6911a989a9;p=linux.git ACPI: bus: Ensure that notify handlers are not running after removal Currently, acpi_device_remove_notify_handler() may return while the notify handler being removed is still running which may allow the module holding that handler to be torn down prematurely. Address this issue by making acpi_device_remove_notify_handler() wait for the handling of all the ACPI events in progress to complete before returning. Fixes: 5894b0c46e49 ("ACPI / scan: Move bus operations and notification routines to bus.c") Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 2f2517d6f9ef9..c32a06bcac0cf 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -589,6 +589,7 @@ static void acpi_device_remove_notify_handler(struct acpi_device *device, acpi_remove_notify_handler(device->handle, type, acpi_notify_device); } + acpi_os_wait_events_complete(); } /* Handle events targeting \_SB device (at present only graceful shutdown) */