From: Kent Overstreet Date: Thu, 5 May 2022 21:20:41 +0000 (-0400) Subject: bcachefs: Delete bch_writepage X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=facc81479cab081cbcb962bfbe5d61f25230d013;p=linux.git bcachefs: Delete bch_writepage Per Dave Chinner and the xfs folks, .writepage is no longer needed, and it's better not to define it if .writepages is the intended path. Signed-off-by: Kent Overstreet --- diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c index 256b3dd0d4aa4..ad51483ad764a 100644 --- a/fs/bcachefs/fs-io.c +++ b/fs/bcachefs/fs-io.c @@ -1469,20 +1469,6 @@ int bch2_writepages(struct address_space *mapping, struct writeback_control *wbc return ret; } -int bch2_writepage(struct page *page, struct writeback_control *wbc) -{ - struct bch_fs *c = page->mapping->host->i_sb->s_fs_info; - struct bch_writepage_state w = - bch_writepage_state_init(c, to_bch_ei(page->mapping->host)); - int ret; - - ret = __bch2_writepage(page_folio(page), wbc, &w); - if (w.io) - bch2_writepage_do_io(&w); - - return ret; -} - /* buffered writes: */ int bch2_write_begin(struct file *file, struct address_space *mapping, diff --git a/fs/bcachefs/fs-io.h b/fs/bcachefs/fs-io.h index 64b16b44e25ae..af905331542dd 100644 --- a/fs/bcachefs/fs-io.h +++ b/fs/bcachefs/fs-io.h @@ -15,7 +15,6 @@ int __must_check bch2_write_inode_size(struct bch_fs *, struct bch_inode_info *, loff_t, unsigned); -int bch2_writepage(struct page *, struct writeback_control *); int bch2_read_folio(struct file *, struct folio *); int bch2_writepages(struct address_space *, struct writeback_control *); diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c index d8cd32b5d765e..b2bc28d0cf051 100644 --- a/fs/bcachefs/fs.c +++ b/fs/bcachefs/fs.c @@ -1113,7 +1113,6 @@ static const struct inode_operations bch_special_inode_operations = { }; static const struct address_space_operations bch_address_space_operations = { - .writepage = bch2_writepage, .read_folio = bch2_read_folio, .writepages = bch2_writepages, .readahead = bch2_readahead,