From: Frank Rowand <frank.rowand@sony.com>
Date: Thu, 26 Mar 2020 01:45:30 +0000 (-0500)
Subject: of: gpio unittest kfree() wrong object
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=fb227f597d612c6660888d1947e68a25fed7b9cc;p=linux.git

of: gpio unittest kfree() wrong object

kernel test robot reported "WARNING: held lock freed!" triggered by
unittest_gpio_remove().  unittest_gpio_remove() was unexpectedly
called due to an error in overlay tracking.  The remove had not
been tested because the gpio overlay removal tests have not been
implemented.

kfree() gdev instead of pdev.

Fixes: f4056e705b2e ("of: unittest: add overlay gpio test to catch gpio hog problem")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Frank Rowand <frank.rowand@sony.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Rob Herring <robh@kernel.org>
---

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 1e5a2e4d893e4..167c8f7a3151d 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1571,7 +1571,7 @@ static int unittest_gpio_remove(struct platform_device *pdev)
 		gpiochip_remove(&gdev->chip);
 
 	platform_set_drvdata(pdev, NULL);
-	kfree(pdev);
+	kfree(gdev);
 
 	return 0;
 }