From: Tom Rix <trix@redhat.com>
Date: Mon, 7 Sep 2020 15:32:25 +0000 (-0700)
Subject: EDAC, sb_edac: Simplify switch statement
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=fbd4ab780284aeb66374223fa3ac0cd47611aebe;p=linux.git

EDAC, sb_edac: Simplify switch statement

clang static analyzer reports this problem

sb_edac.c:959:2: warning: Undefined or garbage value
  returned to caller
        return type;
        ^~~~~~~~~~~

This is a false positive.

However by initializing the type to DEV_UNKNOWN the 3 case can be
removed from the switch, saving a comparison and jump.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Link: https://lore.kernel.org/r/20200907153225.7294-1-trix@redhat.com
---

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index a6704e73fcce5..9a0d53f44baaa 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -939,12 +939,9 @@ static enum dev_type sbridge_get_width(struct sbridge_pvt *pvt, u32 mtr)
 
 static enum dev_type __ibridge_get_width(u32 mtr)
 {
-	enum dev_type type;
+	enum dev_type type = DEV_UNKNOWN;
 
 	switch (mtr) {
-	case 3:
-		type = DEV_UNKNOWN;
-		break;
 	case 2:
 		type = DEV_X16;
 		break;