From: Kent Overstreet <kent.overstreet@gmail.com>
Date: Wed, 1 Sep 2021 22:06:01 +0000 (-0400)
Subject: bcachefs: Improve an error message
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=fbf14104dabe91e6c3b5544f9289eebc94a52c93;p=linux.git

bcachefs: Improve an error message

When we detect an invalid key being inserted, we should print what code
was doing the update.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
---

diff --git a/fs/bcachefs/btree_update_leaf.c b/fs/bcachefs/btree_update_leaf.c
index 3a59f10e0b879..5e57ff5a5ceba 100644
--- a/fs/bcachefs/btree_update_leaf.c
+++ b/fs/bcachefs/btree_update_leaf.c
@@ -577,7 +577,9 @@ static inline int do_bch2_trans_commit(struct btree_trans *trans,
 			char buf[200];
 
 			bch2_bkey_val_to_text(&PBUF(buf), c, bkey_i_to_s_c(i->k));
-			bch_err(c, "invalid bkey %s on insert: %s\n", buf, invalid);
+			bch_err(c, "invalid bkey %s on insert from %ps -> %ps: %s\n",
+				buf, (void *) trans->ip,
+				(void *) i->ip_allocated, invalid);
 			bch2_fatal_error(c);
 		}
 		btree_insert_entry_checks(trans, i);