From: Benjamin Coddington <bcodding@redhat.com>
Date: Thu, 18 Oct 2018 19:01:49 +0000 (-0400)
Subject: nfs: remove redundant call to nfs_context_set_write_error()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=fc187514d8af3a676c7bd7922439f9f5e5c6223f;p=linux.git

nfs: remove redundant call to nfs_context_set_write_error()

We don't need to call this in the direct, read, or pnfs resend paths and
the only other caller is the write path in nfs_page_async_flush() which
already checks and sets the pg_error on the context.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---

diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index 3b50edf6f8833..5c4568a0804b6 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -1174,10 +1174,6 @@ int nfs_pageio_add_request(struct nfs_pageio_descriptor *desc,
 	return 1;
 
 out_failed:
-	/* remember fatal errors */
-	if (nfs_error_is_fatal(desc->pg_error))
-		nfs_context_set_write_error(req->wb_context,
-						desc->pg_error);
 	nfs_pageio_error_cleanup(desc);
 	return 0;
 }