From: Konstantin Khlebnikov <khlebnikov@openvz.org>
Date: Mon, 4 Feb 2013 11:56:01 +0000 (+0400)
Subject: PCI: Catch attempts to disable already-disabled devices
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=fd6dceab017e6be6c158dc56ec6dacf817f21a5b;p=linux.git

PCI: Catch attempts to disable already-disabled devices

Warn when disabling a device that has already been disabled.

[bhelgaas: message wording]
Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
index 5cb5820fae401..29a09b705f04e 100644
--- a/drivers/pci/pci.c
+++ b/drivers/pci/pci.c
@@ -1401,6 +1401,9 @@ pci_disable_device(struct pci_dev *dev)
 	if (dr)
 		dr->enabled = 0;
 
+	dev_WARN_ONCE(&dev->dev, atomic_read(&dev->enable_cnt) <= 0,
+		      "disabling already-disabled device");
+
 	if (atomic_sub_return(1, &dev->enable_cnt) != 0)
 		return;