From: Greg Kurz Date: Tue, 2 May 2017 14:41:43 +0000 (+0200) Subject: scripts/qmp/qom-set: fix the value argument passed to srv.command() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=fe2f74af2b153719fa545ffa7e7a33342d9c928b;p=qemu.git scripts/qmp/qom-set: fix the value argument passed to srv.command() When invoking the script with -s, we end up passing a bogus value to QEMU: $ ./scripts/qmp/qom-set -s /var/tmp/qmp-sock-exp /machine.accel kvm {} $ ./scripts/qmp/qom-get -s /var/tmp/qmp-sock-exp /machine.accel /var/tmp/qmp-sock-exp This happens because sys.argv[2] isn't necessarily the command line argument that holds the value. It is sys.argv[4] when -s was also passed. Actually, the code already has a variable to handle that. This patch simply uses it. Signed-off-by: Greg Kurz Message-Id: <149373610338.5144.9635049015143453288.stgit@bahia.lan> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Signed-off-by: Markus Armbruster --- diff --git a/scripts/qmp/qom-set b/scripts/qmp/qom-set index 54ecfecc53..94e2778922 100755 --- a/scripts/qmp/qom-set +++ b/scripts/qmp/qom-set @@ -61,4 +61,4 @@ else: srv = QEMUMonitorProtocol(socket_path) srv.connect() -print srv.command('qom-set', path=path, property=prop, value=sys.argv[2]) +print srv.command('qom-set', path=path, property=prop, value=value)