From: Julia Lawall <Julia.Lawall@inria.fr>
Date: Sat, 20 Jan 2024 20:56:11 +0000 (+0100)
Subject: coccinelle: device_attr_show: simplify patch case
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ff82e84e80fc0c93095f5a36e0a3508ac121ab80;p=linux.git

coccinelle: device_attr_show: simplify patch case

Replacing the final expression argument by ... allows the format
string to have multiple arguments.

It also has the advantage of allowing the change to be recognized as
a change in a single statement, thus avoiding adding unneeded braces.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---

diff --git a/scripts/coccinelle/api/device_attr_show.cocci b/scripts/coccinelle/api/device_attr_show.cocci
index 634514937e634..550d1d2fc02a9 100644
--- a/scripts/coccinelle/api/device_attr_show.cocci
+++ b/scripts/coccinelle/api/device_attr_show.cocci
@@ -34,15 +34,10 @@ expression BUF, SZ, FORMAT, STR;
 ssize_t show(struct device *dev, struct device_attribute *attr, char *buf)
 {
 	<...
-(
 	return
--		snprintf(BUF, SZ, FORMAT, STR);
-+		sysfs_emit(BUF, FORMAT, STR);
-|
-	return
--		snprintf(BUF, SZ, STR);
-+		sysfs_emit(BUF, STR);
-)
+-		snprintf(BUF, SZ, FORMAT
++		sysfs_emit(BUF, FORMAT
+				,...);
 	...>
 }