From: Samuel Holland Date: Thu, 14 Apr 2022 03:22:55 +0000 (-0500) Subject: phy: rockchip-inno-usb2: Support multi-bit mask properties X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ffe597d04db2b75d9c547a2d2e07c268c2a33117;p=linux.git phy: rockchip-inno-usb2: Support multi-bit mask properties The "bvalid" and "id" interrupts can trigger on either the rising edge or the falling edge, so each interrupt has two enable bits and two status bits. This change allows using a single property for both bits, checking whether either bit is set. Signed-off-by: Samuel Holland Tested-by: Michael Riesch Link: https://lore.kernel.org/r/20220414032258.40984-5-samuel@sholland.org Signed-off-by: Vinod Koul --- diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index 3422db56be76b..c694517496f81 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -253,7 +253,7 @@ static inline bool property_enabled(struct regmap *base, return false; tmp = (orig & mask) >> reg->bitstart; - return tmp == reg->enable; + return tmp != reg->disable; } static int rockchip_usb2phy_clk480m_prepare(struct clk_hw *hw)