fs/ntfs3: Validate attribute data and valid sizes
authorAbdun Nihaal <abdun.nihaal@gmail.com>
Tue, 4 Oct 2022 03:15:02 +0000 (08:45 +0530)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Sat, 12 Nov 2022 17:59:41 +0000 (20:59 +0300)
commit019d22eb0eb707fc099e6e8fad9b3933236a06d0
tree7a9d6d59d1ae87f11ea4f9db29ac190cf71b1381
parent59bfd7a483da36bd202532a3d9ea1f14f3bf3aaf
fs/ntfs3: Validate attribute data and valid sizes

The data_size and valid_size fields of non resident attributes should be
less than the its alloc_size field, but this is not checked in
ntfs_read_mft function.

Syzbot reports a allocation order warning due to a large unchecked value
of data_size getting assigned to inode->i_size which is then passed to
kcalloc.

Add sanity check for ensuring that the data_size and valid_size fields
are not larger than alloc_size field.

Link: https://syzkaller.appspot.com/bug?extid=fa4648a5446460b7b963
Reported-and-tested-by: syzbot+fa4648a5446460b7b963@syzkaller.appspotmail.com
Fixes: (82cae269cfa95) fs/ntfs3: Add initialization of super block
Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/inode.c