irqchip/gic-v3: Fix GICR_CTLR.RWP polling
authorMarc Zyngier <maz@kernel.org>
Tue, 15 Mar 2022 16:50:32 +0000 (16:50 +0000)
committerMarc Zyngier <maz@kernel.org>
Tue, 5 Apr 2022 15:33:13 +0000 (16:33 +0100)
commit0df6664531a12cdd8fc873f0cac0dcb40243d3e9
tree36147a2d0f98184419b7f3236090a33e387012f0
parentaf27e41612ec7e5b4783f589b753a7c31a37aac8
irqchip/gic-v3: Fix GICR_CTLR.RWP polling

It turns out that our polling of RWP is totally wrong when checking
for it in the redistributors, as we test the *distributor* bit index,
whereas it is a different bit number in the RDs... Oopsie boo.

This is embarassing. Not only because it is wrong, but also because
it took *8 years* to notice the blunder...

Just fix the damn thing.

Fixes: 021f653791ad ("irqchip: gic-v3: Initial support for GICv3")
Signed-off-by: Marc Zyngier <maz@kernel.org>
Cc: stable@vger.kernel.org
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Link: https://lore.kernel.org/r/20220315165034.794482-2-maz@kernel.org
drivers/irqchip/irq-gic-v3.c