inet: fix fast path in __inet_hash_connect()
authorPietro Borrello <borrello@diag.uniroma1.it>
Sat, 14 Jan 2023 13:11:41 +0000 (13:11 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 17 Jan 2023 11:02:31 +0000 (12:02 +0100)
commit21cbd90a6fab7123905386985e3e4a80236b8714
tree32e16ce6e95f5d61aa55a6c3db7974f90289c495
parent7875c0189c0d19cb96f2002cb8da6ba447ccc700
inet: fix fast path in __inet_hash_connect()

__inet_hash_connect() has a fast path taken if sk_head(&tb->owners) is
equal to the sk parameter.
sk_head() returns the hlist_entry() with respect to the sk_node field.
However entries in the tb->owners list are inserted with respect to the
sk_bind_node field with sk_add_bind_node().
Thus the check would never pass and the fast path never execute.

This fast path has never been executed or tested as this bug seems
to be present since commit 1da177e4c3f4 ("Linux-2.6.12-rc2"), thus
remove it to reduce code complexity.

Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230112-inet_hash_connect_bind_head-v3-1-b591fd212b93@diag.uniroma1.it
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv4/inet_hashtables.c