power: supply: bq24190: Fix use after free bug in bq24190_remove due to race condition
authorZheng Wang <zyytlz.wz@163.com>
Thu, 9 Mar 2023 17:47:28 +0000 (01:47 +0800)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Thu, 9 Mar 2023 23:35:20 +0000 (00:35 +0100)
commit47c29d69212911f50bdcdd0564b5999a559010d4
tree5bced5242634fe592e9865c251443149bb98103a
parentbf6c880d5d1448489ebf92e2d13d5713ff644930
power: supply: bq24190: Fix use after free bug in bq24190_remove due to race condition

In bq24190_probe, &bdi->input_current_limit_work is bound
with bq24190_input_current_limit_work. When external power
changed, it will call bq24190_charger_external_power_changed
 to start the work.

If we remove the module which will call bq24190_remove to make
cleanup, there may be a unfinished work. The possible
sequence is as follows:

CPU0                  CPUc1

                    |bq24190_input_current_limit_work
bq24190_remove      |
power_supply_unregister  |
device_unregister   |
power_supply_dev_release|
kfree(psy)          |
                    |
                    | power_supply_get_property_from_supplier
                    |   //use

Fix it by finishing the work before cleanup in the bq24190_remove

Fixes: 97774672573a ("power_supply: Initialize changed_work before calling device_add")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/bq24190_charger.c