afs: Hide silly-rename files from userspace
authorDavid Howells <dhowells@redhat.com>
Mon, 8 Jan 2024 17:22:36 +0000 (17:22 +0000)
committerDavid Howells <dhowells@redhat.com>
Mon, 22 Jan 2024 22:29:48 +0000 (22:29 +0000)
commit57e9d49c54528c49b8bffe6d99d782ea051ea534
tree6a340f5d5dc23c8daf8d958b7decf2c0f3d4632b
parentc3d6569a43322f371e7ba0ad386112723757ac8f
afs: Hide silly-rename files from userspace

There appears to be a race between silly-rename files being created/removed
and various userspace tools iterating over the contents of a directory,
leading to such errors as:

find: './kernel/.tmp_cpio_dir/include/dt-bindings/reset/.__afs2080': No such file or directory
tar: ./include/linux/greybus/.__afs3C95: File removed before we read it

when building a kernel.

Fix afs_readdir() so that it doesn't return .__afsXXXX silly-rename files
to userspace.  This doesn't stop them being looked up directly by name as
we need to be able to look them up from within the kernel as part of the
silly-rename algorithm.

Fixes: 79ddbfa500b3 ("afs: Implement sillyrename for unlink and rename")
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
fs/afs/dir.c