net: sparx5: Fix reading of the MAC address
authorHoratiu Vultur <horatiu.vultur@microchip.com>
Mon, 2 Jan 2023 12:12:15 +0000 (13:12 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 2 Jan 2023 13:39:14 +0000 (13:39 +0000)
commit588ab2dc25f60efeb516b4abedb6c551949cc185
tree00117acd2715bcc4fa203cca03ef4d817b978ae4
parent06bf62944144a92d83dd14fd1378d2a288259561
net: sparx5: Fix reading of the MAC address

There is an issue with the checking of the return value of
'of_get_mac_address', which returns 0 on success and negative value on
failure. The driver interpretated the result the opposite way. Therefore
if there was a MAC address defined in the DT, then the driver was
generating a random MAC address otherwise it would use address 0.
Fix this by checking correctly the return value of 'of_get_mac_address'

Fixes: b74ef9f9cb91 ("net: sparx5: Do not use mac_addr uninitialized in mchp_sparx5_probe()")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/microchip/sparx5/sparx5_main.c