i2c: at91: Initialize dma_buf in at91_twi_xfer()
authorNathan Chancellor <nathan@kernel.org>
Thu, 5 May 2022 15:27:38 +0000 (08:27 -0700)
committerWolfram Sang <wsa@kernel.org>
Sat, 14 May 2022 13:41:16 +0000 (15:41 +0200)
commit6977262c2eee111645668fe9e235ef2f5694abf7
treec7fe498b3d6b10c0b80c72bdbacf3b397051bd91
parenta181b8d187319bf265a2019ddde856a3d2f107a6
i2c: at91: Initialize dma_buf in at91_twi_xfer()

Clang warns:

  drivers/i2c/busses/i2c-at91-master.c:707:6: warning: variable 'dma_buf' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
          if (dev->use_dma) {
              ^~~~~~~~~~~~
  drivers/i2c/busses/i2c-at91-master.c:717:27: note: uninitialized use occurs here
          i2c_put_dma_safe_msg_buf(dma_buf, m_start, !ret);
                                   ^~~~~~~

Initialize dma_buf to NULL, as i2c_put_dma_safe_msg_buf() is a no-op
when the first argument is NULL, which will work for the !dev->use_dma
case.

Fixes: 03fbb903c8bf ("i2c: at91: use dma safe buffers")
Link: https://github.com/ClangBuiltLinux/linux/issues/1629
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Michael Walle <michael@walle.cc>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-at91-master.c