char-pty: Print "char device redirected" message to stdout
authorMarkus Armbruster <armbru@redhat.com>
Wed, 17 Apr 2019 19:06:40 +0000 (21:06 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Thu, 18 Apr 2019 20:18:59 +0000 (22:18 +0200)
commit6ade45f2ac936114d82a18ed10df1fb717f4a584
treed397da946db5fbba5e51844f7227fdc1b0275d5f
parentef2fd6f1d1e5333eacaebc8466ed5dbed0d55b8b
char-pty: Print "char device redirected" message to stdout

char_pty_open() prints a "char device redirected to PTY_NAME (label
LABEL)" message to the current monitor or else to stderr.  This is not
an error, so it shouldn't go to stderr.  Print it to stdout instead.

Why is it even printed?  No other ChardevClass::open() prints anything
on success.  It's because you need to know PTY_NAME to actually use
this char device, e.g. like e.g. "socat STDIO,cfmakeraw FILE:PTY_NAME"
to use the monitor's readline interface.  You can get PTY_NAME with
"info chardev" (a.k.a. query-chardev for QMP), but only if you already
have a monitor.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190417190641.26814-15-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
chardev/char-pty.c