eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr_write()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 8 Jul 2022 13:46:38 +0000 (16:46 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Jul 2022 14:53:19 +0000 (16:53 +0200)
commit71d46f1ff2212ced4852c7e77c5176382a1bdcec
tree9226c6185ec84a77f8ef44713a1ff4e714c68512
parent2a3c8f8a4494343f5942b780b3f6295307a07b6e
eeprom: idt_89hpesx: uninitialized data in idt_dbgfs_csr_write()

The simple_write_to_buffer() function will return positive/success if it
is able to write a single byte anywhere within the buffer.  However that
potentially leaves a lot of the buffer uninitialized.

In this code it's better to return 0 if the offset is non-zero.  This
code is not written to support partial writes.  And then return -EFAULT
if the buffer is not completely initialized.

Fixes: cfad6425382e ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Ysg1Pu/nzSMe3r1q@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/eeprom/idt_89hpesx.c