rtc: pcf2127: fix bug when reading alarm registers
authorHugo Villeneuve <hvilleneuve@dimonoff.com>
Tue, 8 Feb 2022 16:29:07 +0000 (11:29 -0500)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Tue, 15 Feb 2022 22:35:43 +0000 (23:35 +0100)
commit73ce05302007eece23a6acb7dc124c92a2209087
tree5b81cf894a8409e0d783d2631cb18e5fb7e70858
parentd4785b46345cc9564f883c94acc4c4de6bbfeea5
rtc: pcf2127: fix bug when reading alarm registers

The first bug is that reading the 5 alarm registers results in a read
operation of 20 bytes. The reason is because the destination buffer is
defined as an array of "unsigned int", and we use the sizeof()
operator on this array to define the bulk read count.

The second bug is that the read value is invalid, because we are
indexing the destination buffer as integers (4 bytes), instead of
indexing it as u8.

Changing the destination buffer type to u8 fixes both problems.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220208162908.3182581-1-hugo@hugovil.com
drivers/rtc/rtc-pcf2127.c