gpio: rockchip: Reset int_bothedge when changing trigger
authorSamuel Holland <samuel@sholland.org>
Sat, 12 Feb 2022 20:50:48 +0000 (14:50 -0600)
committerBartosz Golaszewski <brgl@bgdev.pl>
Wed, 16 Feb 2022 14:52:22 +0000 (15:52 +0100)
commit7920af5c826cb4a7ada1ae26fdd317642805adc2
treee6d8171258cbe68a08272683d478e28555712445
parent754e0b0e35608ed5206d6a67a791563c631cec07
gpio: rockchip: Reset int_bothedge when changing trigger

With v2 hardware, an IRQ can be configured to trigger on both edges via
a bit in the int_bothedge register. Currently, the driver sets this bit
when changing the trigger type to IRQ_TYPE_EDGE_BOTH, but fails to reset
this bit if the trigger type is later changed to something else. This
causes spurious IRQs, and when using gpio-keys with wakeup-event-action
set to EV_ACT_(DE)ASSERTED, those IRQs translate into spurious wakeups.

Fixes: 3bcbd1a85b68 ("gpio/rockchip: support next version gpio controller")
Reported-by: Guillaume Savaton <guillaume@baierouge.fr>
Tested-by: Guillaume Savaton <guillaume@baierouge.fr>
Signed-off-by: Samuel Holland <samuel@sholland.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
drivers/gpio/gpio-rockchip.c