rtc: mc146818-lib: fix locking in mc146818_set_time
authorMateusz Jończyk <mat.jonczyk@o2.pl>
Sun, 20 Feb 2022 09:04:03 +0000 (10:04 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 23 Mar 2022 18:58:37 +0000 (19:58 +0100)
commit811f5559270f25c34c338d6eaa2ece2544c3d3bd
tree1412309dcbdd4f866da1c07d69cd031483740472
parenteb74f47bb6b0c0494d7c90491ee321f3b699f93f
rtc: mc146818-lib: fix locking in mc146818_set_time

In mc146818_set_time(), CMOS_READ(RTC_CONTROL) was performed without the
rtc_lock taken, which is required for CMOS accesses. Fix this.

Nothing in kernel modifies RTC_DM_BINARY, so a separate critical section
is allowed here.

Fixes: dcf257e92622 ("rtc: mc146818: Reduce spinlock section in mc146818_set_time()")
Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220220090403.153928-1-mat.jonczyk@o2.pl
drivers/rtc/rtc-mc146818-lib.c