firewire: remove check of list iterator against head past the loop body
authorJakob Koschel <jakobkoschel@gmail.com>
Sat, 9 Apr 2022 04:12:42 +0000 (13:12 +0900)
committerTakashi Iwai <tiwai@suse.de>
Mon, 25 Apr 2022 06:01:08 +0000 (08:01 +0200)
commit9423973869bd4632ffe669f950510c49296656e0
tree6f7bd3a005e229afadcff2153fcc53b0eb184ff2
parentb7c81f80246fac44077166f3e07103affe6db8ff
firewire: remove check of list iterator against head past the loop body

When list_for_each_entry() completes the iteration over the whole list
without breaking the loop, the iterator value will be a bogus pointer
computed based on the head element.

While it is safe to use the pointer to determine if it was computed
based on the head element, either with list_entry_is_head() or
&pos->member == head, using the iterator variable after the loop should
be avoided.

In preparation to limit the scope of a list iterator to the list
traversal loop, use a dedicated pointer to point to the found element [1].

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Cc: <stable@vger.kernel.org>
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20220409041243.603210-3-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
drivers/firewire/core-transaction.c
drivers/firewire/sbp2.c